On Wed, Apr 18, 2012 at 06:16:02PM +0400, Kirill Yukhin wrote:
> > In any case, I think it ought to check that the 16 reserved bits for memory
> > model is correct (like it use to for the whole enum), and if it isn't, issue
> > the warning and mask in SEQ_CST for the memory model portion.
> Good point. I'll check for overflow masked value there.

And for the 16 bits reserved for target we should IMHO also warn or error on
any unknown bits, otherwise we can't add later on meaning to the further
bits.  So, you could e.g. stick a mask of target bits to warn on into targetm,
default to 0xffff0000 and for i?86/x86_64 clear the two bits in it.

        Jakub

Reply via email to