On 19 April 2012 11:11, Christian Bruel <christian.br...@st.com> wrote:
>
>
> On 04/18/2012 11:51 AM, Richard Guenther wrote:
>> On Wed, Apr 18, 2012 at 11:06 AM, Manuel López-Ibáñez
>> <lopeziba...@gmail.com> wrote:
>>> On 18 April 2012 10:29, Christian Bruel <christian.br...@st.com> wrote:
>>>>
>>>> Is it OK for trunk, bootstrapped and regtested on x86
>>>
>>> I think Joseph Myers is on vacation, and there are no other C FE
>>> reviewers, but since this is c-common and convert.c, perhaps Jason
>>> and/or Richard can review it?
>>
>> The patch is ok if you put the PR52283 properly into a separate testcase,
>> not by amending gcc.dg/case-const-2.c.
>>
>
> Thanks, done at rev #186586. with this change.
Great!
Just a minor nit, for future patches. There is the unwritten rule of
adding the Changelogs to the commit log, like follows:
2012-04-19 Christian Bruel <christian.br...@st.com>
Manuel López-Ibáñez <m...@gcc.gnu.org>
PR c/52283
PR c/37985
* stmt.c (warn_if_unused_value): Skip NOP_EXPR.
* convert.c (convert_to_integer): Don't set TREE_NO_WARNING.
testsuite/
* gcc.dg/pr52283.c: New test.
* gcc.dg/pr37985.c: New test.
Also, if you add to the commit logs the PR numbers like:
PR whatever/NUMBER
PR whatever2/NUMBER
then bugzilla will show the commit on each PR.
Cheers,
Manuel.
