On Wed, Mar 15, 2023 at 9:14 AM Svante Signell <svante.sign...@gmail.com> wrote: > > Package: gcc-snapshot > Version: 1:20230315-1 > Severity: important > Tags: patch > User: debian-h...@lists.debian.org > Usertags: hurd > Affects: gcc-snapshot > X-Debbugs-CC: debian-h...@lists.debian.org > > Hello, seems like the patch gcc_config_gnu.h.diff, in debian gcc-12 named: > pr104290-followup.diff was lost (again). > > How can this patch ever become upstreamed?? > > It seems like sending to gcc-patches is not enough. Create a regression bug? > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104290 is already reported as a > regression, it has to be updated to cover upstream releases of gcc-13 now. > > For gcc-12 Debian has been carrying it as: > pr104290-followup.diff > > Submitting this problem as new bug to Debian/gcc-13/gcc-snapshot! > > Thanks! > > > > ---------- Forwarded message ---------- > From: Svante Signell <svante.sign...@gmail.com> > To: gcc-patches <gcc-patches@gcc.gnu.org> > Cc: Ian Lance Taylor <i...@golang.org>, Matthias Klose <d...@debian.org> > Bcc: > Date: Wed, 23 Feb 2022 11:13:50 +0100 > Subject: [PATCH] gcc-12: Re-enable split-stack support for GNU/Hurd. > Hello, > > In line of porting the latest build of libgo/go with gcc-12 to GNU/Hurd, > support > of split-stack was found to be removed. > > After patching the files in libgo the build of gotools fails: > go1: error: '-fsplit-stack' currently only supported on GNU/Linux > go1: error: '-fsplit-stack' is not supported by this compiler configuration > > The attached patch defines OPTION_GLIBC_P(opts) and OPTION_GLIBC that was lost > in config/gnu.h, needed to enable split-stack support for GNU/Hurd. > > This problem happened with the latest commit as discussed in the mail thread > starting with > https://gcc.gnu.org/pipermail/gcc-patches/2022-January/588973.html > . > > The file first doing this check is: (first error: ..) > src/gcc/common/config/i386/i386-common.cc > in function: > static bool ix86_supports_split_stack (bool report, > struct gcc_options *opts ATTRIBUTE_UNUSED) > > and secondly in:src/gcc/opts.cc: (second error: ...) > in function: > void > finish_options (struct gcc_options *opts, struct gcc_options *opts_set, > location_t loc) > > The checking logic is in function ix86_supports_split_stack(): > #if defined(TARGET_THREAD_SPLIT_STACK_OFFSET) && defined(OPTION_GLIBC_P) > if (!OPTION_GLIBC_P (opts)) > #endif > { > if (report) > error ("%<-fsplit-stack%> currently only supported on GNU/Linux"); > return false; > } > > bool ret = true; > > In case of GNU/Hurd TARGET_THREAD_SPLIT_STACK_OFFSET is defined as well as > OPTION_GLIBC_P but OPTION_GLIBC_P(opts) is needed to. The attached patch to > src/gcc/config/gnu.h creates that definition. For GNU/Hurd, gnu.h is included > in > the configure stage: > Configuring stage 1 in ./gcc > ... > Using the following target machine macro files: > ... > ../../src/gcc/config/gnu.h > > For a longer history about this bug see: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104290 > > Additionally, I would propose the text in > gcc/common/config/i386/i386-common.cc > to change from: > error ("%<-fsplit-stack%> currently only supported on GNU/Linux"); > to: > error ("%<-fsplit-stack%> currently only supported on GLIBC-based systems");
If GNU/Hurd requires glibc, then I think it would be simpler to define OPTION_GLIBC and OPTION_GLIBC_P as true. Adding Thomas Schwinge as the GNU/Hurd maintainer. Ian
