On 5/1/23 21:24, Hans-Peter Nilsson via Gcc-patches wrote:
There may be
minor code quality regressions or there may be minor code quality
improvements -- I'm leaving that for the port maintainers to own going
forward.
Right; I noticed performance regressions, and didn't want to
commit anything that knowingly degraded performance. I did
follow the traces but fell into the rabbit-hole of
rtx_costs. That's the main reason I didn't push a "-mlra"
option or remove the TARGET_LRA_P for CRIS. (My story and I
stick to it.)
But thanks I guess, it saves me a commit, but (to all!)
please sync check_effective_target_lra for targets you
"convert". ...oops, it's just CRIS and hppa there (wot, not
converted?)
Well, I'd say that my plan would be to deprecate any target that is not
converted by the end of this development cycle. So the change keeps
cris from falling into that bucket.
I wasn't aware of check_effective_target_lra. Thanks. I'll make sure
to get that updated as we go forward.
jeff