> I cannot find a call to this debug function on trunk. How exactly did this > trigger a warning?
Here is the command during autoprofiledbootstrap build that resulted in a warning: ~/gcc1_objdir/gcc$ /home/erozen/gcc1_objdir/./prev-gcc/xg++ -B/home/erozen/gcc1_objdir/./prev-gcc/ -B/home/erozen/GCC1/x86_64-pc-linux-gnu/bin/ -nostdinc++ -B/home/erozen/gcc1_objdir/prev-x86_64-pc-linux-gnu/libstdc++-v3/src/.libs -B/home/erozen/gcc1_objdir/prev-x86_64-pc-linux-gnu/libstdc++-v3/libsupc++/.libs -I/home/erozen/gcc1_objdir/prev-x86_64-pc-linux-gnu/libstdc++-v3/include/x86_64-pc-linux-gnu -I/home/erozen/gcc1_objdir/prev-x86_64-pc-linux-gnu/libstdc++-v3/include -I/home/erozen/gcc1/libstdc++-v3/libsupc++ -L/home/erozen/gcc1_objdir/prev-x86_64-pc-linux-gnu/libstdc++-v3/src/.libs -L/home/erozen/gcc1_objdir/prev-x86_64-pc-linux-gnu/libstdc++-v3/libsupc++/.libs -fno-PIE -c -g -O2 -fchecking=1 -DIN_GCC -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Wconditionally-supported -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -Werror -fno-common -DHAVE_CONFIG_H -fauto-profile=cc1plus.fda -I. -I. -I/home/erozen/gcc1_objdir/../gcc1/gcc -I/home/erozen/gcc1_objdir/../gcc1/gcc/. -I/home/erozen/gcc1_objdir/../gcc1/gcc/../include -I/home/erozen/gcc1_objdir/../gcc1/gcc/../libcpp/include -I/home/erozen/gcc1_objdir/../gcc1/gcc/../libcody -I/home/erozen/gcc1_objdir/./gmp -I/home/erozen/gcc1/gmp -I/home/erozen/gcc1_objdir/./mpfr/src -I/home/erozen/gcc1/mpfr/src -I/home/erozen/gcc1/mpc/src -I/home/erozen/gcc1_objdir/../gcc1/gcc/../libdecnumber -I/home/erozen/gcc1_objdir/../gcc1/gcc/../libdecnumber/bid -I../libdecnumber -I/home/erozen/gcc1_objdir/../gcc1/gcc/../libbacktrace -I/home/erozen/gcc1_objdir/./isl/include -I/home/erozen/gcc1/isl/include -o ipa-devirt.o -MT ipa-devirt.o -MMD -MP -MF ./.deps/ipa-devirt.TPo /home/erozen/gcc1_objdir/../gcc1/gcc/ipa-devirt.cc /home/erozen/gcc1_objdir/../gcc1/gcc/ipa-devirt.cc: In function 'void debug_tree_odr_name(tree, bool)': /home/erozen/gcc1_objdir/../gcc1/gcc/ipa-devirt.cc:4037:23: error: '%s' directive argument is null [-Werror=format-overflow=] 4037 | fprintf (stderr, "%s\n", odr); > In any case, IMHO the function should rather print something that makes it > clear that an odr name could not be obtained rather than printing nothing. > I also think that if we want to handle the case, we should do it before also > possibly passing odr to demangler. I'll modify the fix unless we end up suppressing warnings as errors for autoprofiledbootstrap as Richard suggested. Thanks, Martin
