On Wed, 2 May 2012 03:47:17 +0200 (CEST)
Michael Matz <m...@suse.de> wrote:

> There's one thing I'd like an opinion about: I've added two new flags to 
> gimple_statement_base: start_of_seq and end_of_seq, and I had to 
> shorten the uid member by two bits for that.  The two flags are used only 
> for asserts (though they are updated always, they just aren't read except 
> in asserts).  As I'm now finished developing this thing I'm not super sure 
> about the usefullness of the asserts anymore, IIRC they didn't hit very 
> often while developing; rather bugs usually turned into endless loops in 
> sequence walkers.  So, I'd be happy to take them out again, straighten the 
> asserts and leave uid be a normal 32bit integer.  Just tell me.


I believe that uid should stay normal integers. Plugins may find a use for all 
the
available bits. And perhaps even developers of other passes.

Cheers.

-- 
Basile STARYNKEVITCH         http://starynkevitch.net/Basile/
email: basile<at>starynkevitch<dot>net mobile: +33 6 8501 2359
8, rue de la Faiencerie, 92340 Bourg La Reine, France
*** opinions {are only mine, sont seulement les miennes} ***

Reply via email to