Hi, Robin. Can you give me more details of the comments:
What about:
/* As NPATTERNS is always a power of two, we can optimize codegen of
VLA const vector according to this feature. */
Is this comment Ok ? You know I am always struggle with adding an English
comment or description.
Thanks.
juzhe.zh...@rivai.ai
From: Robin Dapp
Date: 2023-06-20 16:03
To: Juzhe-Zhong; gcc-patches
CC: rdapp.gcc; kito.cheng; kito.cheng; palmer; palmer; jeffreyalaw
Subject: Re: [PATCH] RISC-V: Optimize codegen of VLA SLP
> This is a nice improvement. Even though we're in the SLP realm I would
> still add an assert that documents that we're indeed operating with
> pow2_p (NPATTERNS) and some comment as to why we can use AND.
> Sure we're doing exact_log2 et al later anyway, just to make things
> clearer.
Actually no assert necessary, just a comment like:
/* As NPATTERNS is always a power of two, we can ..." */
Regards
Robin
