"juzhe.zh...@rivai.ai" <juzhe.zh...@rivai.ai> writes: > Thanks Richard. > > Do you suggest we should add a macro like this first: > > #ifndef DEF_INTERNAL_COND_FN > #define DEF_INTERNAL_COND_FN(NAME, FLAGS, OPTAB, TYPE) \ > DEF_INTERNAL_OPTAB_FN (COND_##NAME, FLAGS, cond_##optab, cond_##TYPE) > DEF_INTERNAL_OPTAB_FN (COND_LEN_##NAME, FLAGS, cond_len_##optab, > cond_len_##TYPE) > #endif
Yeah. (Think there's a missing backslash though.) > If yes, maybe I should first do this in a single patch first? Yeah, doing it as a separate patch sounds good. Richard