On Mon, Sep 18, 2023 at 02:22:50PM +0200, Tobias Burnus wrote:
> The attached patch now actually adds GOMP_alloc/free calls for 'omp allocate'.
> 
> Besides the addition of the calls and the value expression, it also had to 
> deal with
> (implicit) mapping/privatization - such that 'default(none)' did not wrongly 
> trigger
> for the value expression (and categorizes the vars correctly for 
> default/defaultmap)
> and that mapping/privatization is handled correctly.
> 
> Build and regtested on x86-64-gnu-linux (w/o offloading configured, but I 
> tested
> separately the libgomp.c/allocate-*.c with nvptx offloading).
> 
> Comments, suggestions, remarks?

LGTM.

        Jakub

Reply via email to