Re: [PATCH] aarch64: Ensure const and sign correctness

[Richard Sandiford]

Pekka Seppänen <p...@gcc.mail.kapsi.fi> writes:
> Be const and sign correct by using a matching CIE augmentation type.
> Use a builtin instead of relying <string.h> being included.
>
> libgcc/ChangeLog:
>
>       * config/aarch64/aarch64-unwind.h (aarch64_cie_signed_with_b_key):
>       Use const unsigned type and a builtin.

Thanks for the patch, pushed to trunk.

Richard

> Signed-off-by: Pekka Seppänen <p...@gcc.mail.kapsi.fi>
> ---
>  libgcc/config/aarch64/aarch64-unwind.h | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/libgcc/config/aarch64/aarch64-unwind.h 
> b/libgcc/config/aarch64/aarch64-unwind.h
> index 3ad2f8239ed..d669edd671b 100644
> --- a/libgcc/config/aarch64/aarch64-unwind.h
> +++ b/libgcc/config/aarch64/aarch64-unwind.h
> @@ -40,8 +40,9 @@ aarch64_cie_signed_with_b_key (struct _Unwind_Context 
> *context)
>        const struct dwarf_cie *cie = get_cie (fde);
>        if (cie != NULL)
>       {
> -       char *aug_str = cie->augmentation;
> -       return strchr (aug_str, 'B') == NULL ? 0 : 1;
> +       const unsigned char *aug_str = cie->augmentation;
> +       return __builtin_strchr ((const char *) aug_str,
> +                                'B') == NULL ? 0 : 1;
>       }
>      }
>    return 0;