On 10/4/23 15:29, Jeff Law wrote:
On 10/4/23 16:21, Patrick O'Neill wrote:
On 10/4/23 15:14, Jeff Law wrote:
On 10/4/23 15:57, Patrick O'Neill wrote:
Since r14-4358-g9464e72bcc9 riscv_v targets use vector instructions to
perform a memcpy. We no longer expect memcpy for riscv_v targets.
gcc/testsuite/ChangeLog:
* gcc.dg/pr90263.c: xfail riscv_v targets.
Or rather than XFAIL skip the test? XFAIL kind of implies its
something we'd like to fix. But in this case we don't want a memcpy
call as the inlined vector implementation is almost certainly better.
Ah. Since XFAIL notifies us if a test starts passing (via xpass) I
thought it would help us ensure the test doesn't start passing
on riscv_v. I didn't know it implied something needed to be fixed.
I'll rework it to skip riscv_v targets.
Hopefully that works.
If you wanted a test to verify that we don't go backwards and start
emitting a memcpy, you can set up a test like
// dg-directives
#include "pr90263.c"
// dg directives for scanning
Where the scanning verifies that we don't have a call to memcpy. The
kind of neat thing here is the dg directives in the included file are
ignored, so you can use the same test sources in multiple ways.
Given this is kindof specific to risc-v, it might make more sense in
the riscv directory.
Jeff
Title changed/superseded by:
https://inbox.sourceware.org/gcc-patches/20231004225527.930610-1-patr...@rivosinc.com/T/#u
Patrick
