On 10/15/23 04:39, Tobias Burnus wrote:
@@ -905,8 +905,8 @@ For @code{omp_sched_auto} the @var{chunk_size} argument is
ignored.
@subsection @code{omp_get_schedule} -- Obtain the runtime scheduling method
@table @asis
@item @emph{Description}:
-Obtain the runtime scheduling method. The @var{kind} argument will be
-set to the value @code{omp_sched_static}, @code{omp_sched_dynamic},
+Obtain the runtime scheduling method. The @var{kind} argument is set to
+to @code{omp_sched_static}, @code{omp_sched_dynamic},
You've introduced an extra "to" here.
@@ -3029,7 +3029,7 @@
OMP_ALLOCATOR=omp_low_lat_mem_space:pinned=true,partition=nearest
Sets the format string used when displaying OpenMP thread affinity information.
Special values are output using @code{%} followed by an optional size
specification and then either the single-character field type or its long
-name enclosed in curly braces; using @code{%%} will display a literal percent.
+name enclosed in curly braces; using @code{%%} displays a literal percent.
The size specification consists of an optional @code{0.} or @code{.} followed
by a positive integer, specifying the minimal width of the output. With
@code{0.} and numerical values, the output is padded with zeros on the left;
I think all the @code markups here ought to be @samp, but let's not do that in
this patch.
-If set to @code{DISABLED}, then offloading is disabled and all code will run on
-the host. If set to @code{DEFAULT}, the program will try offloading to the
+If set to @code{DISABLED}, then offloading is disabled and all code runs on
+the host. If set to @code{DEFAULT}, the program tries offloading to the
device first, then fall back to running code on the host if it cannot.
Missed one here; s/[will] fall back/falls back/.
@@ -3559,7 +3559,7 @@ Binds threads to specific CPUs. The variable should
contain a space-separated
or comma-separated list of CPUs. This list may contain different kinds of
entries: either single CPU numbers in any order, a range of CPUs (M-N)
or a range with some stride (M-N:S). CPU numbers are zero based. For example,
-@code{GOMP_CPU_AFFINITY="0 3 1-2 4-15:2"} will bind the initial thread
+@code{GOMP_CPU_AFFINITY="0 3 1-2 4-15:2"} binds the initial thread
to CPU 0, the second to CPU 3, the third to CPU 1, the fourth to
CPU 2, the fifth to CPU 4, the sixth through tenth to CPUs 6, 8, 10, 12,
and 14 respectively and then start assigning back from the beginning of
Similarly, s/[will] start/starts/.
@item @emph{C/C++}:
@@ -3983,8 +3983,8 @@ but might be removed in a future version of GCC.
@table @asis
@item @emph{Description}
This function tests for completion of the asynchronous operation specified
-in @var{arg}. In C/C++, a non-zero value will be returned to indicate
-the specified asynchronous operation has completed. While Fortran will return
+in @var{arg}. In C/C++, a non-zero value is returned to indicate
+the specified asynchronous operation has completed. While Fortran returns
a @code{true}. If the asynchronous operation has not completed, C/C++ returns
a zero and Fortran returns a @code{false}.
Hmmmm. How about s/, While/while/ here. And it sounds odd to me to say "a
true" or a "a zero"; I'd suggest deleting the indefinite article from all those
uses.
@@ -4012,8 +4012,8 @@ a zero and Fortran returns a @code{false}.
@table @asis
@item @emph{Description}
This function tests for completion of all asynchronous operations.
-In C/C++, a non-zero value will be returned to indicate all asynchronous
-operations have completed. While Fortran will return a @code{true}. If
+In C/C++, a non-zero value is returned to indicate all asynchronous
+operations have completed. While Fortran returns a @code{true}. If
any asynchronous operation has not completed, C/C++ returns a zero and
Fortran returns a @code{false}.
Ditto here.
@@ -4196,9 +4196,9 @@ This function shuts down the runtime for the device type specified in
This function returns whether the program is executing on a particular
device specified in @var{devicetype}. In C/C++ a non-zero value is
returned to indicate the device is executing on the specified device type.
-In Fortran, @code{true} will be returned. If the program is not executing
-on the specified device type C/C++ will return a zero, while Fortran will
-return @code{false}.
+In Fortran, @code{true} is returned. If the program is not executing
+on the specified device type C/C++ will return a zero, while Fortran
You missed a "will return" here, and same issues with "a zero".
@@ -5178,7 +5178,7 @@ subsequent to the calls to @code{acc_copyin()}.
As seen in the previous use case, a call to @code{cublasCreate()}
initializes the CUBLAS library and allocates the hardware resources on the
host and the device. However, since the device has already been allocated,
-@code{cublasCreate()} will only initialize the CUBLAS library and allocate
+@code{cublasCreate()} only initializes the CUBLAS library and allocate
s/[will] allocate/allocates/
@@ -5267,7 +5267,7 @@ possible for the (very common) case that the Profiling
Interface is
not enabled. This is relevant, as the Profiling Interface affects all
the @emph{hot} code paths (in the target code, not in the offloaded
code). Users of the OpenACC Profiling Interface can be expected to
-understand that performance will be impacted to some degree once the
+understand that performance is impacted to some degree once the
Profiling Interface has gotten enabled: for example, because of the
While you're at it, please s/has gotten/is/ to put that in the present tense
too.
OK with those changes.
-Sandra
