Re: [PATCH V2 00/14] Refactor and cleanup vsetvl pass

Patrick O'Neill Tue, 17 Oct 2023 13:25:45 -0700

Hi Lehua!

I ran the gcc testsuite on qemu before/after applying your patches to305034e3 rv32/64gcv [1].


Baseline
               ========= Summary of gcc testsuite =========

| # of unexpected case / # of uniqueunexpected case

                            |          gcc |          g++ | gfortran |
    rv32gcv/ ilp32d/ medlow |  208 /    78 |   29 /    17 |   71 /    24 |
    rv64gcv/  lp64d/ medlow |  101 /    54 |   13 /     4 |   33 /    13 |

After applying patch series:
               ========= Summary of gcc testsuite =========

| # of unexpected case / # of uniqueunexpected case

                            |          gcc |          g++ | gfortran |
    rv32gcv/ ilp32d/ medlow |  256 /    96 |   29 /    17 |   69 /    23 |
    rv64gcv/  lp64d/ medlow |  152 /    74 |   13 /     4 |   31 /    12 |

I'm seeing:
20 new unique gcc failures on rv64gcv [2]
18 new unique gcc failures on rv32gcv [3]

Thanks,
Patrick

[1] Build commands:
git clone https://github.com/patrick-rivos/riscv-gnu-toolchain.git
cd riscv-gnu-toolchain
git submodule update --init gcc
cd gcc
git checkout 305034e3
cd ..
mkdir build
cd build

../configure --prefix=$(pwd)--with-multilib-generator="rv64gcv-lp64d--;rv32gcv-ilp32d--"

make report-linux -j32

Note: If you'd prefer to use upstream riscv-gnu-toolchain, I'm prettysure you can do

mkdir build-64
cd build-64
../configure --prefix=$(pwd) --with-arch=rv64gcv --with-abi=lp64d
cd ..
mkdir build-32
cd build-32
../configure --prefix=$(pwd) --with-arch=rv32gcv --with-abi=lp32d
This'll make 2 folders, so run make report-linux in each of them.

[2] rv64gcv New failures:
FAIL: gcc.dg/vect/slp-7.c -flto -ffat-lto-objects execution test
FAIL: gcc.dg/vect/slp-7.c execution test

FAIL: gcc.target/riscv/zero-scratch-regs-2.c -O3 -g scan-assembler-not\\mvsetvliFAIL: gcc.target/riscv/rvv/vsetvl/avl_single-34.c -O1scan-assembler-times vsetvli 1FAIL: gcc.target/riscv/rvv/vsetvl/avl_single-34.c -O2scan-assembler-times vsetvli 1FAIL: gcc.target/riscv/rvv/vsetvl/avl_single-34.c -O2 -flto-fno-use-linker-plugin -flto-partition=none scan-assembler-times vsetvli 1FAIL: gcc.target/riscv/rvv/vsetvl/avl_single-34.c -O2 -flto-fuse-linker-plugin -fno-fat-lto-objects scan-assembler-times vsetvli 1FAIL: gcc.target/riscv/rvv/vsetvl/avl_single-34.c -Osscan-assembler-times vsetvli 1FAIL: gcc.target/riscv/rvv/vsetvl/avl_single-37.c -O1scan-assembler-times vsetvli 3FAIL: gcc.target/riscv/rvv/vsetvl/avl_single-37.c -O2scan-assembler-times vsetvli 3FAIL: gcc.target/riscv/rvv/vsetvl/avl_single-37.c -O2 -flto-fno-use-linker-plugin -flto-partition=none scan-assembler-times vsetvli 3FAIL: gcc.target/riscv/rvv/vsetvl/avl_single-37.c -O2 -flto-fuse-linker-plugin -fno-fat-lto-objects scan-assembler-times vsetvli 3FAIL: gcc.target/riscv/rvv/vsetvl/avl_single-37.c -Osscan-assembler-times vsetvli 3FAIL: gcc.target/riscv/rvv/vsetvl/avl_single-38.c -O1scan-assembler-times vsetvli 4FAIL: gcc.target/riscv/rvv/vsetvl/avl_single-38.c -O2scan-assembler-times vsetvli 4FAIL: gcc.target/riscv/rvv/vsetvl/avl_single-38.c -O2 -flto-fno-use-linker-plugin -flto-partition=none scan-assembler-times vsetvli 4FAIL: gcc.target/riscv/rvv/vsetvl/avl_single-38.c -O2 -flto-fuse-linker-plugin -fno-fat-lto-objects scan-assembler-times vsetvli 4FAIL: gcc.target/riscv/rvv/vsetvl/avl_single-47.c -O1scan-assembler-times vsetvli 2FAIL: gcc.target/riscv/rvv/vsetvl/avl_single-47.c -O2scan-assembler-times vsetvli 2FAIL: gcc.target/riscv/rvv/vsetvl/avl_single-47.c -O2 -flto-fno-use-linker-plugin -flto-partition=none scan-assembler-times vsetvli 2FAIL: gcc.target/riscv/rvv/vsetvl/avl_single-47.c -O2 -flto-fuse-linker-plugin -fno-fat-lto-objects scan-assembler-times vsetvli 2FAIL: gcc.target/riscv/rvv/vsetvl/avl_single-47.c -Osscan-assembler-times vsetvli 2FAIL: gcc.target/riscv/rvv/vsetvl/avl_single-48.c -O1scan-assembler-times vsetvli 2FAIL: gcc.target/riscv/rvv/vsetvl/avl_single-48.c -O2scan-assembler-times vsetvli 2FAIL: gcc.target/riscv/rvv/vsetvl/avl_single-48.c -O2 -flto-fno-use-linker-plugin -flto-partition=none scan-assembler-times vsetvli 2FAIL: gcc.target/riscv/rvv/vsetvl/avl_single-48.c -O2 -flto-fuse-linker-plugin -fno-fat-lto-objects scan-assembler-times vsetvli 2FAIL: gcc.target/riscv/rvv/vsetvl/avl_single-49.c -O1scan-assembler-times vsetvli 2FAIL: gcc.target/riscv/rvv/vsetvl/avl_single-49.c -O2scan-assembler-times vsetvli 2FAIL: gcc.target/riscv/rvv/vsetvl/avl_single-49.c -O2 -flto-fno-use-linker-plugin -flto-partition=none scan-assembler-times vsetvli 2FAIL: gcc.target/riscv/rvv/vsetvl/avl_single-49.c -O2 -flto-fuse-linker-plugin -fno-fat-lto-objects scan-assembler-times vsetvli 2FAIL: gcc.target/riscv/rvv/vsetvl/avl_single-49.c -Osscan-assembler-times vsetvli 2FAIL: gcc.target/riscv/rvv/vsetvl/avl_single-65.c -O2scan-assembler-times vsetvli 3FAIL: gcc.target/riscv/rvv/vsetvl/avl_single-65.c -O2 -flto-fno-use-linker-plugin -flto-partition=none scan-assembler-times vsetvli 3FAIL: gcc.target/riscv/rvv/vsetvl/avl_single-65.c -O2 -flto-fuse-linker-plugin -fno-fat-lto-objects scan-assembler-times vsetvli 3FAIL: gcc.target/riscv/rvv/vsetvl/pr111037-2.c -O0 scan-assembler-notvsetvliFAIL: gcc.target/riscv/rvv/vsetvl/pr111037-2.c -O1 scan-assembler-notvsetvliFAIL: gcc.target/riscv/rvv/vsetvl/pr111037-2.c -O2 scan-assembler-notvsetvliFAIL: gcc.target/riscv/rvv/vsetvl/pr111037-2.c -O2 -flto-fno-use-linker-plugin -flto-partition=none scan-assembler-not vsetvliFAIL: gcc.target/riscv/rvv/vsetvl/pr111037-2.c -O2 -flto-fuse-linker-plugin -fno-fat-lto-objects scan-assembler-not vsetvliFAIL: gcc.target/riscv/rvv/vsetvl/pr111037-2.c -O3 -gscan-assembler-not vsetvliFAIL: gcc.target/riscv/rvv/vsetvl/pr111037-2.c -Os scan-assembler-notvsetvliFAIL: gcc.target/riscv/rvv/vsetvl/vlmax_single_block-10.c -O3 -g scan-assembler-times vsetvli 15FAIL: gcc.target/riscv/rvv/vsetvl/vlmax_single_block-11.c -O3 -g scan-assembler-times vsetvli 3FAIL: gcc.target/riscv/rvv/vsetvl/vlmax_single_block-12.c -O3 -g scan-assembler-times vsetvli 9FAIL: gcc.target/riscv/rvv/vsetvl/vlmax_single_block-13.c -O3 -g scan-assembler-times vsetvli 9FAIL: gcc.target/riscv/rvv/vsetvl/vlmax_single_block-14.c -O3 -g scan-assembler-times vsetvli 1FAIL: gcc.target/riscv/rvv/vsetvl/vlmax_single_block-15.c -O3 -g scan-assembler-times vsetvli 4FAIL: gcc.target/riscv/rvv/vsetvl/vlmax_single_block-16.c -O3 -g scan-assembler-times vsetvli 15FAIL: gcc.target/riscv/rvv/vsetvl/vlmax_single_block-18.c -O3 -g scan-assembler-times vsetvli 3FAIL: gcc.target/riscv/rvv/vsetvl/vlmax_single_block-19.c -O3 -g scan-assembler-times vsetvli 15FAIL: gcc.target/riscv/rvv/vsetvl/vlmax_single_block-9.c -O3 -g scan-assembler-times vsetvli 15


[3] rv32gcv New failures:


On 10/17/23 04:34, Lehua Ding wrote:

This patch refactors and cleanups the vsetvl pass in order to make the code
easier to modify and understand. This patch does several things:

1. Introducing a virtual CFG for vsetvl infos and Phase 1, 2 and 3 only maintain
    and modify this virtual CFG. Phase 4 performs insertion, modification and
    deletion of vsetvl insns based on the virtual CFG. The Basic block in the
    virtual CFG is called vsetvl_block_info and the vsetvl information inside
    is called vsetvl_info.
2. Combine Phase 1 and 2 into a single Phase 1 and unified the demand system,
    this Phase only fuse local vsetvl info in forward direction.
3. Refactor Phase 3, change the logic for determining whether to uplift vsetvl
    info to a pred basic block to a more unified method that there is a vsetvl
    info in the vsetvl defintion reaching in compatible with it.
4. Place all modification operations to the RTL in Phase 4 and Phase 5.
    Phase 4 is responsible for inserting, modifying and deleting vsetvl
    instructions based on fully optimized vsetvl infos. Phase 5 removes the avl
    operand from the RVV instruction and removes the unused dest operand
    register from the vsetvl insns.

These modifications resulted in some testcases needing to be updated. The 
reasons
for updating are summarized below:

1. more optimized
    vlmax_back_prop-25.c/vlmax_back_prop-26.c/vlmax_conflict-3.c/
    vlmax_conflict-12.c/vsetvl-13.c/vsetvl-23.c/
    avl_single-23.c/avl_single-89.c/avl_single-95.c/pr109773-1.c
2. less unnecessary fusion
    avl_single-46.c/imm_bb_prop-1.c/pr109743-2.c/vsetvl-18.c
3. local fuse direction (backward -> forward)
    scalar_move-1.c/
4. add some bugfix testcases.
    pr111037-3.c/pr111037-4.c
    avl_single-89.c

        PR target/111037
        PR target/111234
        PR target/111725


Lehua Ding (14):
   RISC-V: P1: Refactor avl_info/vl_vtype_info/vector_insn_info
   RISC-V: P2: Refactor and cleanup demand system
   RISC-V: P3: Refactor class vector_infos_manager to pre_vsetvl
   RISC-V: P4: move method from class pass_vsetvl to pre_vsetvl
   RISC-V: P5: combine phase 1 and 2 into a single pahse
   RISC-V: P6: Add compute reaching definition data flow
   RISC-V: P7: Move earliest fuse and lcm code to pre_vsetvl class
   RISC-V: P8: Unified insert and delete of vsetvl insn into Phase 4
   RISC-V: P9: Cleanup post optimize phase
   RISC-V: P10: Cleanup helper functions
   RISC-V: P11:  Refactor vector_block_info to vsetvl_block_info class
   RISC-V: P12: Delete riscv-vsetvl.h
   RISC-V: P13:  Reorganize functions used to modify RTL
   RISC-V: P14: Adjust and add testcases

  gcc/config/riscv/riscv-vsetvl.cc              | 6530 +++++++----------
  gcc/config/riscv/riscv-vsetvl.def             |  634 +-
  gcc/config/riscv/riscv-vsetvl.h               |  488 --
  gcc/config/riscv/t-riscv                      |    2 +-
  .../gcc.target/riscv/rvv/base/pr111037-2.c    |    8 -
  .../gcc.target/riscv/rvv/base/scalar_move-1.c |    2 +-
  .../riscv/rvv/vsetvl/avl_single-104.c         |   35 +
  .../riscv/rvv/vsetvl/avl_single-105.c         |   23 +
  .../riscv/rvv/vsetvl/avl_single-23.c          |    7 +-
  .../riscv/rvv/vsetvl/avl_single-46.c          |    3 +-
  .../riscv/rvv/vsetvl/avl_single-89.c          |    8 +-
  .../riscv/rvv/vsetvl/avl_single-95.c          |    2 +-
  .../riscv/rvv/vsetvl/imm_bb_prop-1.c          |    7 +-
  .../gcc.target/riscv/rvv/vsetvl/pr109743-2.c  |    2 +-
  .../gcc.target/riscv/rvv/vsetvl/pr109773-1.c  |    2 +-
  .../gcc.target/riscv/rvv/vsetvl/pr111037-3.c  |   16 +
  .../pr111037-1.c => vsetvl/pr111037-4.c}      |    5 +-
  .../riscv/rvv/vsetvl/vlmax_back_prop-25.c     |   10 +-
  .../riscv/rvv/vsetvl/vlmax_back_prop-26.c     |   10 +-
  .../riscv/rvv/vsetvl/vlmax_conflict-12.c      |    1 -
  .../riscv/rvv/vsetvl/vlmax_conflict-3.c       |    2 +-
  .../gcc.target/riscv/rvv/vsetvl/vsetvl-13.c   |    4 +-
  .../gcc.target/riscv/rvv/vsetvl/vsetvl-18.c   |    4 +-
  .../gcc.target/riscv/rvv/vsetvl/vsetvl-23.c   |    2 +-
  24 files changed, 3084 insertions(+), 4723 deletions(-)
  delete mode 100644 gcc/config/riscv/riscv-vsetvl.h
  delete mode 100644 gcc/testsuite/gcc.target/riscv/rvv/base/pr111037-2.c
  create mode 100644 gcc/testsuite/gcc.target/riscv/rvv/vsetvl/avl_single-104.c
  create mode 100644 gcc/testsuite/gcc.target/riscv/rvv/vsetvl/avl_single-105.c
  create mode 100644 gcc/testsuite/gcc.target/riscv/rvv/vsetvl/pr111037-3.c
  rename gcc/testsuite/gcc.target/riscv/rvv/{base/pr111037-1.c => 
vsetvl/pr111037-4.c} (74%)

--
2.36.3

Re: [PATCH V2 00/14] Refactor and cleanup vsetvl pass

Reply via email to