On 10/17/23 14:48, Alex Coplan wrote:
haifa-sched.cc:remove_notes asserts that it lands on a real (non-note)
insn after advancing past NOTE_INSN_EPILOGUE_BEG, but with the upcoming
post-RA aarch64 load pair pass enabled, we can land on
NOTE_INSN_DELETED.
This patch adjusts remove_notes to remove these if they occur at the
start of the epilogue instead of asserting.
Bootstrapped/regtested as a series on aarch64-linux-gnu, OK for trunk?
gcc/ChangeLog:
* haifa-sched.cc (remove_notes): Allow for NOTE_INSN_DELETED at
the start of the epilgoue, remove these.
One could argue that the pass should have actually deleted the insn
rather than just turned it into a NOTE_INSN_DELETED. Is there some
reason that's not done? A NOTE_INSN_DELETED carries no useful information.
+ /* Skip over any NOTE_INSN_DELETED at the start of the epilogue.
+ */
Don't bring the close comment down to a new line. If it fits, but it on
the last line of the actual comment. Otherwise bring down part of
comment so that we don't have the close comment on a line by itself.
Jeff
