On Thu, 26 Oct 2023 at 23:40, Gerald Pfeifer <ger...@pfeifer.com> wrote: > > On Thu, 26 Oct 2023, Sam James wrote: > > These options both enabled more checking within the C++ standard library > > and can expose errors in submitted code. > > This is a good addition, thank you! I was going to approve/push, but it's > probably better for Jonathan to give the final okay.
LGTM, I'll push it. > > Just one question: > > > +... If either of these fail, this is a strong indicator > > +of an error in your code.</p> > > What does "fails" mean in this context? Are we looking at build failures? > Run-time failures? Run-time. Defining those macros should not cause build failures, although if they do that's probably a bug in the user code too.
