On 11/1/23 12:11, Jeff Law wrote:
On 10/31/23 12:35, Vineet Gupta wrote:
riscv_promote_function_mode doesn't promote a SI to DI for libcalls
case.
The fix is what generic promote_mode () in explow.cc does. I really
don't understand why the old code didn't work, but stepping thru the
debugger shows old code didn't and fixed does.
This showed up when testing Ajit's REE ABI extension series which probes
the ABI (using a NULL tree type) and ends up hitting the libcall code
path.
[Usual caveat, I'll wait for Pre-commit CI to run the tests and report]
gcc/ChangeLog:
* config/riscv/riscv.cc (riscv_promote_function_mode): Fix mode
returned for libcall case.
Macro that change their arguments are evil ;( I think Juzhe's patch
in this space a few months back wasn't supposed to change behavior.
Oh, its a regression. I can add a Fixes: tag
OK once CI finishes without regressions.
Thx,
-Vineet
