Thanks Jeff. Just finish bootstrap +regression passed. Committed.
juzhe.zh...@rivai.ai From: Jeff Law Date: 2023-11-07 11:52 To: Juzhe-Zhong; gcc-patches CC: rguenther Subject: Re: [PATCH] test: Fix FAIL of SAD tests for RVV On 11/6/23 20:36, Juzhe-Zhong wrote: > RVV didn't explicitly enable SAD optab but we can vectorize it > since loop vectorizer is able to recognize SAD pattern for RVV during > analysis. > > Current scan check of explicit SAD pattern looks odd, > it should be more reasonable to check recognition of SAD pattern during Loop > vectorize analysis. > > Other SAD tests like slp-reduc-sad-2.c are checking pattern recognition > instead of explicit pattern enable. > Fix SAD dump check to fix the FAILS for RVV. > > gcc/testsuite/ChangeLog: > > * gcc.dg/vect/slp-reduc-sad.c: Fix check. > * gcc.dg/vect/vect-reduc-sad.c: Ditto. OK after verifying this doesn't introduce an unexpected fail on at least one major platform -- I'd recommend x86. You can greatly speed up testing with: make check-gcc RUNTESTFLAGS=vect.exp=slp-reduc-sad.c make check-gcc RUNTESTFLAGS=slp-reduc-sad.c That way you just have to build the stage1 x86 compiler, do that quick test rather than a full bootstrap and regression run. jeff
