On 2023/12/14 4:52, Thomas Schwinge wrote: > Hi Lipeng! > > On 2023-12-12T02:05:26+0000, "Zhu, Lipeng" <lipeng....@intel.com> wrote: > > On 2023/12/12 1:45, H.J. Lu wrote: > >> On Sat, Dec 9, 2023 at 7:25 PM Zhu, Lipeng <lipeng....@intel.com> > wrote: > >> > On 2023/12/9 23:23, Jakub Jelinek wrote: > >> > > On Sat, Dec 09, 2023 at 10:39:45AM -0500, Lipeng Zhu wrote: > >> > > > This patch try to introduce the rwlock and split the read/write > >> > > > to unit_root tree and unit_cache with rwlock instead of the > >> > > > mutex to increase CPU efficiency. In the get_gfc_unit function, > >> > > > the percentage to step into the insert_unit function is around > >> > > > 30%, in most instances, we can get the unit in the phase of > >> > > > reading the unit_cache or unit_root tree. So split the > >> > > > read/write phase by rwlock would be an approach to make it more > parallel. > >> > > > > >> > > > BTW, the IPC metrics can gain around 9x in our test server with > >> > > > 220 cores. The benchmark we used is > >> > > > https://github.com/rwesson/NEAT > > >> > > Ok for trunk, thanks. > > >> > Thanks! Looking forward to landing to trunk. > > >> Pushed for you. > > > Thanks for everyone's patience and help, really appreciate that! > > Congratulations on your first contribution to GCC (as far as I can tell)! > :-) > > > I've just filed <https://gcc.gnu.org/PR113005> > "'libgomp.fortran/rwlock_1.f90', 'libgomp.fortran/rwlock_3.f90' execution > test timeouts". > Would you be able to look into that? > > > Grüße > Thomas > ----------------- > Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, > 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: > Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; > Registergericht München, HRB 106955
Hi Thomas, Sure, I will look into that. BTW, I didn’t have the PowerPC in hands, do you mind granting the access of your test environment to me to help reproduce the issue? Lipeng Zhu
