emit_library_call_value_1 calls emit_push_insn with NULL_TREE
for TYPE.  Sometimes emit_push_insn needs to assign a temp with
that TYPE, which causes a segfault.

Fixed by computing the TYPE from MODE when needed.

Original patch by Thorsten Otto.

gcc/

2024-01-03  Thorsten Otto  <ad...@tho-otto.de>
            Mikael Pettersson  <mikpeli...@gmail.com>

        PR target/82420
        PR target/111279
        * expr.cc (emit_push_insn): If TYPE is NULL compute it
        from MODE before calling assign_temp.

gcc/teststuite/

2024-01-03  Mikael Pettersson  <mikpeli...@gmail.com>

        PR target/82420
        * gcc.target/m68k/pr82420.c: New test.
---
 gcc/expr.cc                             | 6 +++++-
 gcc/testsuite/gcc.target/m68k/pr82420.c | 9 +++++++++
 2 files changed, 14 insertions(+), 1 deletion(-)
 create mode 100644 gcc/testsuite/gcc.target/m68k/pr82420.c

diff --git a/gcc/expr.cc b/gcc/expr.cc
index 9fef2bf6585..7ab80ef176c 100644
--- a/gcc/expr.cc
+++ b/gcc/expr.cc
@@ -5304,7 +5304,11 @@ emit_push_insn (rtx x, machine_mode mode, tree type, rtx 
size,
          size = gen_int_mode (GET_MODE_SIZE (mode), Pmode);
          if (!MEM_P (xinner))
            {
-             temp = assign_temp (type, 1, 1);
+             tree atype = type;
+
+             if (atype == NULL_TREE)
+               atype = lang_hooks.types.type_for_mode (mode, 0);
+             temp = assign_temp (atype, 1, 1);
              emit_move_insn (temp, xinner);
              xinner = temp;
            }
diff --git a/gcc/testsuite/gcc.target/m68k/pr82420.c 
b/gcc/testsuite/gcc.target/m68k/pr82420.c
new file mode 100644
index 00000000000..5c84f292103
--- /dev/null
+++ b/gcc/testsuite/gcc.target/m68k/pr82420.c
@@ -0,0 +1,9 @@
+/* { do-do compile } */
+/* { dg-options "-march=68000 -malign-int" } */
+
+int a;
+
+void f(void)
+{
+    a /= 3;
+}
-- 
2.43.0

Reply via email to