On Wed, 2024-01-03 at 00:41 +0000, Joseph Myers wrote:
> On Tue, 2 Jan 2024, David Malcolm wrote:
>
> > > > + #print(f'{url_suffix=} {index_text=}')
> > >
> > > Various commented-out or "if 0" debugging code like this should
> > > probably
> > > be removed (or made into an actual runtime conditional if
> > > desired).
> >
> > I've removed them all.
>
> There are still a few left.
Oops; sorry about that.
> The patch is OK with the remaining
> commented-out code removed or made into runtime conditionals.
Thanks. I removed the commented-out code, rebased, reran the unit
tests, regenerated the .opt.urls files, and retested the resulting
patch kit successfully (on x86_64-pc-linux-gnu with all langs+jit
enabled).
I've now pushed the patch kit to trunk as these four commits:
options: add gcc/regenerate-opt-urls.py:
r14-6920-g9e49746da303b8
Add generated .opt.urls files:
r14-6921-g5bb18475a10d05
opts: add logic to generate options-urls.cc:
r14-6922-g6ecc1e32353e33
options: wire up options-urls.cc into gcc_urlifier:
r14-6923-g4ded42c2c5a5c9
Thanks
Dave
