Yes, as Juzhe said I had run all the riscv regression, but without RTL check. I will fix it. Sorry for forgetting to enable RTL checking for testing. Thanks Juzhe for helping me reverse this commit. From: juzhe.zh...@rivai.ai Date: 2024-01-05 11:28 To: palmer CC: gcc-patches; kito.cheng; Kito.cheng Subject: Re: Re: [committed] RISC-V: Add crypto vector builtin function. We (me and kito) has reviewed vector-crypto.
I believe Wang Feng has done && passed the regression (with no RTL check), but he just didn't enable RTL check I guessed. (By default, RTL check is disabled in riscv-gnu-toolchain, developers need to enable it manually). It's ok to revert the patch, then commit it after he fixes the ICE with enabling RTL check. juzhe.zh...@rivai.ai From: Palmer Dabbelt Date: 2024-01-05 11:24 To: juzhe.zhong CC: gcc-patches; Kito Cheng; Kito.cheng Subject: Re: [committed] RISC-V: Add crypto vector builtin function. On Thu, 04 Jan 2024 19:17:21 PST (-0800), juzhe.zh...@rivai.ai wrote: > Hi, Wang Feng. > > Your patch has some ICEs: > FAIL: gcc.target/riscv/rvv/base/zvbc-intrinsic.c (internal compiler error: > RTL check: expected code 'const_int', have 'reg' in vlmax_avl_type_p, at > config/riscv/riscv-v.cc:4930) > FAIL: gcc.target/riscv/rvv/base/zvbc-intrinsic.c (test for excess errors) > FAIL: gcc.target/riscv/rvv/base/zvbc_vx_constraint-1.c (internal compiler > error: RTL check: expected code 'const_int', have 'reg' in vlmax_avl_type_p, > at config/riscv/riscv-v.cc:4930) > FAIL: gcc.target/riscv/rvv/base/zvbc_vx_constraint-1.c (test for excess > errors) > FAIL: gcc.target/riscv/rvv/base/zvbc_vx_constraint-2.c (internal compiler > error: RTL check: expected code 'const_int', have 'reg' in vlmax_avl_type_p, > at config/riscv/riscv-v.cc:4930) > FAIL: gcc.target/riscv/rvv/base/zvbc_vx_constraint-2.c (test for excess > errors) So let's just revert it, it doesn't even look like it was reviewed. We've set a really bad precedent here where we're just merging a bunch of unreviewed code and sorting out the regressions in trunk, that's not the right way to do things. > > I suspect you didn't enable rtl check in the regression: > > ../../configure --enable-gcc-checking=rtl. > Plz enable rtl check in the regression tests. > > > > juzhe.zh...@rivai.ai
