Re: [COMMITTED V3 4/4] RISC-V: Enable assert for insn_has_dfa_reservation

[Edwin Lu]

On 1/25/2024 9:06 AM, Robin Dapp wrote:

    /* If we ever encounter an insn without an insn reservation, trip
       an assert so we can find and fix this problem.  */
-#if 0
+  if (! insn_has_dfa_reservation_p (insn)) {
+    print_rtl(stderr, insn);
+    fprintf(stderr, "%d", get_attr_type (insn));
+  }
    gcc_assert (insn_has_dfa_reservation_p (insn));
-#endif

return more - 1;

  }

I was thinking about make the gcc_assert a gcc_checking_assert so,
in case we accidentally forget something at any point, it would
only gracefully degrade in a release build.  As we already have
a hard assert for the type the patch (and not many test with
enable checking anyway) this is OK IMHO.

I suppose you tested with all available -mtune options?

Regards
  Robin

Committed without the debugging stuff!

Edwin