On Tue, Feb 06, 2024 at 10:00:18AM +0100, Rainer Orth wrote:
> 2024-02-01 Rainer Orth <r...@cebitec.uni-bielefeld.de>
>
> libgcc:
> * config/i386/libgcc-sol2.ver (GCC_14.0.0): Added all symbols from
> i386/libgcc-glibc.ver (GCC_12.0.0, GCC_13.0.0, GCC_14.0.0).
> * config/i386/libgcc-glibc.ver: Request notifications on updates.
LGTM, except for a nit:
> # HG changeset patch
> # Parent e582765ce980229b4c3ae5afc6a28e5aa480cdaf
> libgcc: Export i386 symbols added after GCC_7.0.0 on Solaris [PR113700]
>
> diff --git a/libgcc/config/i386/libgcc-glibc.ver
> b/libgcc/config/i386/libgcc-glibc.ver
> --- a/libgcc/config/i386/libgcc-glibc.ver
> +++ b/libgcc/config/i386/libgcc-glibc.ver
> @@ -236,3 +236,7 @@ GCC_14.0.0 {
> __floatbitintxf
> __floatbitinttf
> }
> +
> +# Please notify the maintainers of libgcc-{bsd,darwin,sol2}.ver of any
> +# additions. Those version scripts usually need to be kept in sync with
> +# libgcc-glibc.ver.
> diff --git a/libgcc/config/i386/libgcc-sol2.ver
> b/libgcc/config/i386/libgcc-sol2.ver
> --- a/libgcc/config/i386/libgcc-sol2.ver
> +++ b/libgcc/config/i386/libgcc-sol2.ver
> @@ -115,3 +115,39 @@ GCC_4.8.0 {
> GCC_7.0.0 {
> __signbittf2
> }
> +
> +GCC_14.0.0 {
> + # Added to GCC_12.0.0 in i386/libgcc-glibc.
> + # Added to GCC_13.0.0 in i386/libgcc-glibc.
> + # Added to GCC_14.0.0 in i386/libgcc-glibc.
Please append
ver.
to these comment lines.
Jakub
