Hi Richard, Thanks for the review!
TARGET_ARM64_MS_ABI refers to the official Microsoft ARM64 ABI naming used for the target. If AARCH64 is a more preferred name, it will be changed in PATCH v2. https://learn.microsoft.com/en-us/cpp/build/arm64-windows-abi-conventions?view=msvc-170 Regards, Evgeny -----Original Message----- Thursday, February 22, 2024 2:11 PM Richard Earnshaw (lists) wrote: On 21/02/2024 18:30, Evgeny Karpov wrote: > + tm_defines="${tm_defines} TARGET_ARM64_MS_ABI=1" I missed this on first reading... The GCC port name uses AARCH64, please use that internally rather than other names. The only time when we should be using ARM64 is when it's needed for compatibility with other compilers and that doesn't apply here AFAICT. R.
