On 06/06/2012 01:11 PM, Bruce Korb wrote:
On 06/06/12 09:33, rbmj wrote:
Hi everyone,

OK, I'm slow.  I just woke up from a late night.  "test -r vxWorks.h"
is the mechanism to ensure that tests only fire on a vxworks platform.
Seems a bit obscure, but if it is easier than other mechanisms, then
fine.  I do think a "mach" test would be much more straight forward:

* mach - Match the output of config.guess against a series of fnmatch patterns. It must match at least one of the patterns, unless
               "not-machine" has also been specified.  In that case, the
               config.guess output must not match any of the patterns.

<snip />
and even then, it should be researched as to whether or not you need
to prefix the touched file name with "${SRCDIR}/" because I don't remember.
I still think:

    mach = "*-*-vxworks*";

is more straight forward, and you can then eliminate the touchy vxWorks.h
thingy.

The version that I posted in the original thread is not the latest version. The patches that I've sent to -patches all use the mach test, not the test idiom.

Robert Mason

Reply via email to