On Tue, Mar 19, 2024 at 01:06:50PM +0100, Richard Biener wrote:
> The following reverts the chrec_fold_multiply fix and only keeps
> handling of constant overflow which keeps the original testcase
> fixed.  A better solution might involve ranger improvements or
> tracking of assumptions during SCEV analysis similar to what niter
> analysis does.
> 
> Bootstrapped and tested on x86_64-unknown-linux-gnu.
> 
> OK for trunk?  Or do you prefer to not fix the INTEGER_CST case
> either?
> 
> Thanks,
> Richard.
> 
>       PR tree-optimization/114151
>       PR tree-optimization/114269
>       PR tree-optimization/114322
>       PR tree-optimization/114074
>       * tree-chrec.cc (chrec_fold_multiply): Restrict the use of
>       unsigned arithmetic when actual overflow on constant operands
>       is observed.
> 
>       * gcc.dg/pr68317.c: Revert last change.

LGTM.

        Jakub

Reply via email to