On Fri, Apr 12, 2024 at 1:10 AM HAO CHEN GUI <guih...@linux.ibm.com> wrote: > > Hi, > This patch adds an optab for __builtin_isnormal. The normal check can be > implemented on rs6000 by a single instruction. It needs an optab to be > expanded to the certain sequence of instructions. > > The subsequent patches will implement the expand on rs6000. > > Bootstrapped and tested on x86 and powerpc64-linux BE and LE with no > regressions. Is this OK for next stage-1?
This is missing adding documentation for the new optab. It should be documented in md.texi under `Standard Pattern Names For Generation` section. Thanks, Andrew > > Thanks > Gui Haochen > ChangeLog > optab: Add isnormal_optab for isnormal builtin > > gcc/ > * builtins.cc (interclass_mathfn_icode): Set optab to isnormal_optab > for isnormal builtin. > * optabs.def (isnormal_optab): New. > > patch.diff > diff --git a/gcc/builtins.cc b/gcc/builtins.cc > index 3174f52ebe8..defb39de95f 100644 > --- a/gcc/builtins.cc > +++ b/gcc/builtins.cc > @@ -2462,6 +2462,7 @@ interclass_mathfn_icode (tree arg, tree fndecl) > case BUILT_IN_ISFINITE: > builtin_optab = isfinite_optab; break; > case BUILT_IN_ISNORMAL: > + builtin_optab = isnormal_optab; break; > CASE_FLT_FN (BUILT_IN_FINITE): > case BUILT_IN_FINITED32: > case BUILT_IN_FINITED64: > diff --git a/gcc/optabs.def b/gcc/optabs.def > index dcd77315c2a..3c401fc0b4c 100644 > --- a/gcc/optabs.def > +++ b/gcc/optabs.def > @@ -353,6 +353,7 @@ OPTAB_D (hypot_optab, "hypot$a3") > OPTAB_D (ilogb_optab, "ilogb$a2") > OPTAB_D (isinf_optab, "isinf$a2") > OPTAB_D (isfinite_optab, "isfinite$a2") > +OPTAB_D (isnormal_optab, "isnormal$a2") > OPTAB_D (issignaling_optab, "issignaling$a2") > OPTAB_D (ldexp_optab, "ldexp$a3") > OPTAB_D (log10_optab, "log10$a2")
