Hmm, there were now two daily bumps:
Date: Mon May 20 00:16:30 2024 +0000
Date: Sun May 19 18:15:28 2024 +0000
I really wonder why.
I guess, the 'ignore commit' is hence not needed – but I think the
improved diagnostic part still makes sense.
See updated patch.
On May 19, 24 Tobias Burnus wrote:
I noticed that the last bump happened on Thursday.
* * *
The error is according to
https://gcc.gnu.org/pipermail/gccadmin/2024q2/021298.html
2024-05-19 00:17:28,643:INFO:root:cannot find a ChangeLog location in
message
That's the commit
---------------
Revert "Revert: "Enable prange support.""
This reverts commit d7bb8eaade3cd3aa70715c8567b4d7b08098e699 and
enables prange
support again.
---------------
* * * The attached patch adds this commit to the ignore list and helps
with the diagnosis by showing the failing hash in the error message.
OK for mainline?
Post commit: Can someone install the new version + fix the ChangeLog
for the ignored commit?
* * *
What I do not understand: Why does this commit get applied? I do see
for both
contrib/gcc-changelog/git_check_commit.py -v -p
da73261ce7731be7f2b164f1db796878cdc23365
and
contrib/gcc-changelog/git_email.py
0001-Revert-Revert-Enable-prange-support.patch the error above. - And
I do not understand why it made it past the commit check but now fails?
Likewise for8057f9aa1f7e70490064de796d7a8d42d446caf8
Does the commit hook use an older version of the check scripts? Does
it ignore the errors? Or what goes wrong here? Any idea?
Tobias
From f56b1764f2b5c2c83c6852607405e5be0a763a2c Mon Sep 17 00:00:00 2001
From: Tobias Burnus <tbur...@baylibre.com>
Date: Sun, 19 May 2024 08:17:42 +0200
Subject: [PATCH] contrib/gcc-changelog/git_update_version.py: Improve diagnostic
contrib/ChangeLog:
* gcc-changelog/git_update_version.py (prepend_to_changelog_files): Output
git hash in case errors occurred.
diff --git a/contrib/gcc-changelog/git_update_version.py b/contrib/gcc-changelog/git_update_version.py
index 24f6c43d0b2..ec0151b83fe 100755
--- a/contrib/gcc-changelog/git_update_version.py
+++ b/contrib/gcc-changelog/git_update_version.py
@@ -58,6 +58,7 @@ def read_timestamp(path):
def prepend_to_changelog_files(repo, folder, git_commit, add_to_git):
if not git_commit.success:
+ logging.info(f"While processing {git_commit.info.hexsha}:")
for error in git_commit.errors:
logging.info(error)
raise AssertionError()
--
2.45.0
