On Thu, May 23, 2024 at 10:35 AM Uros Bizjak <ubiz...@gmail.com> wrote: > > On Wed, May 22, 2024 at 4:32 PM Evgeny Karpov > <evgeny.kar...@microsoft.com> wrote: > > > > Wednesday, May 22, 2024 1:06 PM > > Richard Sandiford <richard.sandif...@arm.com> wrote: > > > > > This looks good to me apart from a couple of very minor comments below, > > > but > > > please get approval from the x86 maintainers as well. In particular, > > > they might > > > prefer to handle ix86_legitimize_pe_coff_symbol in some other way. > > > > Thanks, Richard, for the review! > > The suggestions will be addressed in the next version. > > > > Jan and Uros, could you please review x86 refactoring for mingw part? > > Thanks. > > Yes, perhaps legitimize_pe_coff_symbol should be handled similar to > how machopic_legitimize_pic_address is handled.and just use "#if > TARGET_PECOFF" at call sites when calling functions from the new > winnt-dll.h. This would also allow us to remove the early check for > !TARGET_PECOFF in legitimize_pe_coff_symbol.
Maybe you should look how TARGET_MACHO is handled in config/i386/* files. Uros.
