Hi Chung-Lin, I think tune_marvell attribute better be kept for future Marvell cores extension. Thanks!
B.R. Yi-Hsiu, Hsu -----Original Message----- From: Chung-Lin Tang [mailto:clt...@codesourcery.com] Sent: Tuesday, June 26, 2012 12:12 PM To: Yi-Hsiu Hsu Cc: Ramana Radhakrishnan; gcc-patches@gcc.gnu.org Subject: Re: [PATCH, ARM] New CPU support for Marvell PJ4 cores On 2012/6/26 09:37 AM, Yi-Hsiu Hsu wrote: > Updated changelog. > > * config/arm/marvell-pj4.md: New marvell-pj4 pipeline description. > * config/arm/arm.c (arm_issue_rate): Add marvell_pj4. > * config/arm/arm.md (tune_marvell): Add marvell_pj4. > * config/arm/arm-cores.def: Add core marvell-pj4. > * config/arm/arm-tune.md: Regenerated. > * config/arm/arm-tables.opt: Regenerated. > * config/arm/bpabi.h (BE8_LINK_SPEC): Add marvell_pj4. > * doc/invoke.texi: Added entry for marvell-pj4. Another nit, I think the tune_marvell attribute now looks a bit unneeded. You can just fold it into the "tune" clause of "generic_sched". Thanks, Chung-Lin