> This won't apply as I've already updated those tests. I think verifying > the number of SAT_ADDs is useful to ensure we don't regress as some of > these tests detect > 1 SAT_ADD idiom.
I see, thanks Jeff. Then drop this patch. Pan -----Original Message----- From: Jeff Law <jeffreya...@gmail.com> Sent: Thursday, September 5, 2024 10:10 AM To: Li, Pan2 <pan2...@intel.com>; gcc-patches@gcc.gnu.org Cc: juzhe.zh...@rivai.ai; kito.ch...@gmail.com; rdapp....@gmail.com Subject: Re: [PATCH v1] RISC-V: Fix SAT_* dump check failure due to middle-end change. On 9/4/24 8:01 PM, pan2...@intel.com wrote: > From: Pan Li <pan2...@intel.com> > > Some middl-end change may effect on the times of .SAT_*. Thus, > refine the dump check for SAT_*, from the scan-times to scan as > we only care about the .SAT_* exist or not. And there will an > other PATCH to perform similar refinement and this PATCH only > fix the failed test cases. This won't apply as I've already updated those tests. I think verifying the number of SAT_ADDs is useful to ensure we don't regress as some of these tests detect > 1 SAT_ADD idiom. jeff
