On Wed, 16 Oct 2024 at 16:58, Tom Tromey <t...@tromey.com> wrote: > > >>>>> "Jonathan" == Jonathan Wakely <jwak...@redhat.com> writes: > > Jonathan> Using a keyword argument for count only became possible with Python > 3.1 > Jonathan> so introduce a new function to do the substitution. > > gdb docs are inconsistent on this, but at least one spot says that the > minimum supported Python version is 3.2. Plus, I know we agreed that > the minimum should be 3.4, and I'll be sending a patch to this effect > soon. > > Anyway, I think it would be reasonably safe to just assume 3.1 if you > want to do that.
We still have a few places in the printers.py file that check for Python 3 vs Python 2, so I did so here too. For the Python 3 case, I'm assuming 3.1 or later, because I can imagine some people might be stuck on Python 2 for some reason (and also unable to build GDB with Python 3? ... maybe unlikely) but nobody should be stuck on 3.0 and unable to replace that with 3.12 or so. So the condition is Python 2x, or Python 3.1+, and Python 3.0 is unsupported. If we no longer care about Python 2 there are a few places in that file we could clean up.