On Wed, 16 Oct 2024, Jakub Jelinek wrote: > On Tue, Oct 15, 2024 at 05:40:58PM +0000, Joseph Myers wrote: > > > --- gcc/testsuite/gcc.dg/cpp/c23-delimited-escape-seq-1.c.jj > > > 2024-10-14 17:58:54.436815339 +0200 > > > +++ gcc/testsuite/gcc.dg/cpp/c23-delimited-escape-seq-1.c 2024-10-14 > > > 17:59:05.032666716 +0200 > > > @@ -0,0 +1,87 @@ > > > +/* P2290R3 - Delimited escape sequences */ > > > > I don't think the comments on this and other C tests should reference a > > C++ paper. > > Ok, changed. > > > I think there should also be tests using digit separators with the 0o / 0O > > prefixes (both valid cases, and testing the error for having the digit > > separator immediately after 0o / 0O). > > Done. Also added test for 0b1'01 because we only had test for invalid 0b'0 > and 0B'1. > > Tested on x86_64-linux and i686-linux, ok for trunk?
This version is OK. -- Joseph S. Myers josmy...@redhat.com
