On Fri, 2024-11-01 at 11:22 +0800, Xi Ruoyao wrote: > On Thu, 2024-10-31 at 23:18 +0000, Joseph Myers wrote: > > On Thu, 31 Oct 2024, David Malcolm wrote: > > > > > That said, I think setting LANG=C when running selftests is > > > probably > > > the best solution. How does the attached (untested) patch look? > > > > LC_ALL takes precedence over LANG. OK with LC_ALL instead of or > > alongside > > LANG (assuming that passes testing). > > I agree, for example > > LANG=C LC_MESSAGES=zh_CN.UTF-8 LC_CTYPE=C.UTF-8 gcc > > still outputs Chinese messages. > > LC_ALL=C should be OK (I used LC_ALL=C make -j8 for building GCC > yesterday to work around this issue).
Thanks. I updated the patch to use LC_ALL, successfully bootstrapped and regression-tested with it, and have pushed it as r15-4840- g8e95e064ea73d4. Dave > > > (Note: some platforms may use UTF-8 for the C locale; there's > > support in > > the testsuite for using C.ASCII instead on Cygwin for that reason. > > This > > matters if you're testing the use of ASCII versus Unicode quotes in > > diagnostics.) >
