On 16/07/2012, at 6:37 PM, Chung-Lin Tang wrote: > On 2012/7/16 12:28 AM, Richard Sandiford wrote: >> Chung-Lin Tang <clt...@codesourcery.com> writes: >>> This patch adds scheduling support for the NetLogic XLP, including a new >>> pipeline description, and associated changes. >>> >>> Asides from the new xlp.md description file, there are also some sync >>> primitive attribute modifications, for better scheduling of sync loops >>> (Maxim should be able to better explain this). >> >> Rather than add a "type" attribute to each sync loop, please just add: >> >> (not (eq_attr "sync_mem" "none")) >> (symbol_ref "syncloop") >> >> to the default value of the "type" attribute. You'll probably need >> to swap the order of the sync* attributes with the "type" attribute >> in order for this to compile. >> >> The patch is effectively changing the type of the sync loops from >> "unknown" to "syncloop". That's certainly OK, but you'll need to >> add "syncloop" to the "unknown" reservations of all other schedulers >> (except for generic.md, where what you've done instead is fine). >> It might be easier if you split out the addition of syncloop >> as a separate patch. > > I'll leave it to Maxim to respond to the sync parts.
Richard, that's indeed simpler, thanks. Chung-Lin, I'll try to make a patch for the patch in the next couple of days and will send it to you. Let me know if you'd rather fixed this yourself. ... >> Tested on mips64-elf, and by making sure that there were no changes in >> -O2 output for a recent set of cc1 .ii files. Applied. >> >> I'm probably punishing you for being honest here, but the only other >> thing is that you've listed NetLogic Microsystems Inc. as one of the >> authors. I think that means they'll need to sign a copyright assignment. >> Have they already done that? > > They have assigned the copyright to Mentor Graphics, so it should mean > the code can be contributed by us. That is correct. NetLogic developed the original xlp.md description, which Chung-Lin essentially rewrote. In any case, Mentor has copyright assignment for the original xlp.md specifically so that we can contribute this upstream. Thank you, -- Maxim Kuvyrkov CodeSourcery / Mentor Graphics
