On Thu, Jul 19, 2012 at 4:50 PM, Moore, Catherine <catherine_mo...@mentor.com> wrote: > Hi, > > The microMIPS port benefits from an additional peephole2 pass. Sched2 > exposes some opportunities to recognize the movep instruction. > Does this look okay to commit?
Not really. The purpose of peephole2 was to do peephole optimizations before *final* scheduling. Maybe this patch works for MIPS, but you could seriously ruin performance on machines where scheduling matters. (And even on MIPS, how do you handle pipeline hazards?) Ciao! Steven