> -----Original Message-----
> From: Jakub Jelinek <ja...@redhat.com>
> Sent: Sunday, March 16, 2025 13:55
> To: Robert Dubner <rdub...@symas.com>
> Cc: gcc-patches@gcc.gnu.org
> Subject: Re: [PATCH] cobol: add cobol.dg/group1/escape.cob test; modify
> cobol.dg/gd.exp to handle it
>
> On Sun, Mar 16, 2025 at 11:40:33AM -0500, Robert Dubner wrote:
> > Once more into the breach...
> >
> > These changes work on x86_64-linux
> >
> > Okay for trunk?
> >
> > cobol: add cobol.dg/group1/escape.cob test; modify cobol.dg/gd.exp to
> > handle it
> >
> > gcc/testsuite
> >
> > * cobol.dg/dg.exp: modified to recurse into directories
without
>
> Capital letter on Modified
>
> > .exp files and find *.cob files therein
>
> Missing dot after therein
>
> > * cobol.dg/group1/escape.cob: New testcase
>
> And here as well.
> > --- /dev/null
> > +++ b/gcc/testsuite/cobol.dg/group1/escape.cob
> > @@ -0,0 +1,11 @@
> > +*> { dg-do run }
> > +*> { dg-output {Testing the testing(\n|\r\n|\r)} }
> > +*> { dg-output {\.\^\$\*\+\-\?\(\)\[\]\{\}\\\|(\n|\r\n|\r)} }
> > +*> { dg-output {"\.\^\$\*\+\-\?\(\)\[\]\{\}\\\|"(\n|\r\n|\r)} }
>
> Please drop this last (\n|\r\n|\r)
> As I tried to explain, it can cause havoc with remote testing.
> Just
> *> { dg-output {"\.\^\$\*\+\-\?\(\)\[\]\{\}\\\|"} }
> as the last dg-output will do here.
> If you need in some case ensure that what is being matched is the last
> thing printed, just print something else from the program afterwards
> and match that too.
>
> > + identification division.
> > + program-id. escape.
> > + procedure division.
> > + display "Testing the testing"
> > + display ".^$*+-?()[]{}\|"
> > + display '".^$*+-?()[]{}\|"' .
> > + end program escape.
>
> Otherwise LGTM.
>
> Jakub
Thanks. And, pushed. And, crap. I missed the capital M on modified.
The other changes, the periods and removing the final newline test, I
managed to apply.
I'm getting the idea.
