> -----Original Message-----
> From: Jakub Jelinek <ja...@redhat.com>
> Sent: Monday, March 17, 2025 16:05
> To: Iain Sandoe <idsan...@googlemail.com>
> Cc: Robert Dubner <rdub...@symas.com>; GCC Patches <gcc-
> patc...@gcc.gnu.org>
> Subject: Re: [PATCH] cobol: Eliminate CPPFLAGS assignment from Make-
> lang.in [PR119213].
> 
> On Mon, Mar 17, 2025 at 07:57:43PM +0000, Iain Sandoe wrote:
> > >   PR cobol/119213
> > >   * Make-lang.in:   Eliminate CPPFLAGS= assignment.
> > >   * cdf.y:          Modify #includes that reference libgcobol.
> > >   * cobol1.cc:      Modify #includes that reference libgcobol.
> > >   * except.cc:      Modify #includes that reference libgcobol.
> > >   * gcobolspec.cc:  Modify #includes that reference libgcobol.
> > >   * genapi.cc:      Modify #includes that reference libgcobol.
> > >   * gengen.cc:      Modify #includes that reference libgcobol.
> > >   * genmath.cc:     Modify #includes that reference libgcobol.
> > >   * genutil.cc:     Modify #includes that reference libgcobol.
> > >   * parse.y:        Modify #includes that reference libgcobol.
> > >   * scan.l:         Modify #includes that reference libgcobol.
> > >   * structs.cc:     Modify #includes that reference libgcobol.
> > >   * symbols.cc:     Modify #includes that reference libgcobol.
> > >   * symfind.cc:     Modify #includes that reference libgcobol.
> > >   * util.cc:        Modify #includes that reference libgcobol.
> 
> Plus for ChangeLog formatting again
> s/: *\([EM]\)/: \1/
> 
>       Jakub

I will, of course, make that change.  But I can't help but ask: Is there
some reason for eliminating the spaces that cause the comments to line up?

I did it, reflexively, because I think that lining stuff like that up iss
easier to understand and more clear than.

        PR cobol/119213
        * Make-lang.in: Eliminate CPPFLAGS= assignment.
        * cdf.y: Modify #includes that reference libgcobol.
        * cobol1.cc: Modify #includes that reference libgcobol.
        * except.cc: Modify #includes that reference libgcobol.
        * gcobolspec.cc: Modify #includes that reference libgcobol.
        * genapi.cc: Modify #includes that reference libgcobol.
        * gengen.cc: Modify #includes that reference libgcobol.
        * genmath.cc: Modify #includes that reference libgcobol.
        * genutil.cc: Modify #includes that reference libgcobol.
        * parse.y: Modify #includes that reference libgcobol.
        * scan.l: Modify #includes that reference libgcobol.
        * structs.cc: Modify #includes that reference libgcobol.
        * symbols.cc: Modify #includes that reference libgcobol.
        * symfind.cc: Modify #includes that reference libgcobol.
        * util.cc: Modify #includes that reference libgcobol.

Meanwhile I am going to take all this as a "good to go", once I fix the
comment and my libgfortran typo.

Reply via email to