On Fri, Apr 04, 2025 at 12:48:56PM +0200, Jakub Jelinek wrote:
> On Thu, Apr 03, 2025 at 12:07:53PM +0530, Tejas Belagod wrote:
> > Add compile-only OpenMP error tests for target clause used with SVE types.
> >
> > gcc/testsuite/ChangeLog:
> >
> > * gcc.target/aarch64/sve/gomp/gomp.exp: Test driver.
> > * gcc.target/aarch64/sve/gomp/target-device.c: New test.
> > * gcc.target/aarch64/sve/gomp/target-link.c: Likewise.
> > * gcc.target/aarch64/sve/gomp/target.c: Likewise.
>
> LGTM.
Actually one thing.
Can you please rename the function names from
omp_target_* to just target_* ?
The omp_ identifier prefix is reserved to official OpenMP APIs, while it
is unlikely these names will clash with future additions to the standard,
it is better not to give bad example.
Jakub
