On Sun, 4 May 2025, John Paul Adrian Glaubitz wrote:

> Hi,
> 
> On Sun, 2025-05-04 at 11:18 +0200, John Paul Adrian Glaubitz wrote:
> > On Fri, 2025-05-02 at 12:12 +0200, Richard Biener wrote:
> > > This flips the default to LRA for targets with an -mlra option not
> > > using Mask(..).
> > > 
> > >   * config/avr/avr.opt (mlra): Flip to default on.
> > >   * config/m68k/m68k.opt (mlra): Likewise.
> > >   * config/pa/pa.opt (mlra): Likewise.
> > >   * config/sh/sh.opt (mlra): Likewise.
> > > ---
> > >  gcc/config/avr/avr.opt   | 2 +-
> > >  gcc/config/m68k/m68k.opt | 2 +-
> > >  gcc/config/pa/pa.opt     | 2 +-
> > >  gcc/config/sh/sh.opt     | 2 +-
> > >  4 files changed, 4 insertions(+), 4 deletions(-)
> > > 
> > > diff --git a/gcc/config/avr/avr.opt b/gcc/config/avr/avr.opt
> > > index fcd2bf68f2a..3aa4955361b 100644
> > > --- a/gcc/config/avr/avr.opt
> > > +++ b/gcc/config/avr/avr.opt
> > > @@ -19,7 +19,7 @@
> > >  ; <http://www.gnu.org/licenses/>.
> > >  
> > >  mlra
> > > -Target Var(avropt_lra_p) UInteger Init(0) Optimization Undocumented
> > > +Target Var(avropt_lra_p) UInteger Init(1) Optimization Undocumented
> > >  Usa LRA for reload instead of the old reload framework.  This option is 
> > > experimental, and it may be removed in future versions of the compiler.
> > >  
> > >  mcall-prologues
> > > diff --git a/gcc/config/m68k/m68k.opt b/gcc/config/m68k/m68k.opt
> > > index 35f86ba11ff..b664425c5a1 100644
> > > --- a/gcc/config/m68k/m68k.opt
> > > +++ b/gcc/config/m68k/m68k.opt
> > > @@ -147,7 +147,7 @@ Target RejectNegative Mask(LONG_JUMP_TABLE_OFFSETS)
> > >  Use 32-bit offsets in jump tables rather than 16-bit offsets.
> > >  
> > >  mlra
> > > -Target Var(m68k_lra_p) Undocumented
> > > +Target Var(m68k_lra_p) Init(1) Undocumented
> > >  Usa LRA for reload instead of the old reload framework.  This option is
> > >  experimental, and it may be removed in future versions of the compiler.
> > 
> > I just applied this patch against master and did a full native bootstrap 
> > with
> > all languages except Ada, Go, Rust and Cobol on Debian unstable m68k which 
> > worked
> > without any problems. Full build log in [1].
> > 
> > I therefore suggest to flip the switch for m68k now with reference to 
> > PR113939 [2]
> > so that we can close this bug and tick off m68k on the list of targets to 
> > be switched
> > to LRA by default.
> 
> I just noticed that my builds were with --disable-bootstrap. *sigh*

Note I'd consider that "fine", it gives you a build that was able to
build libgcc and thus it will allow you to make check and debug
from there (with nice small testcases).

> Let me try that again.

Please note any findings in the respective PRs as well.

Note I'm waiting for approval on the www change with any actual change
(maintainers can go ahead themselves of course).

Richard.

Reply via email to