On Mon, 12 May 2025 at 16:46, Alejandro Colomar <a...@kernel.org> wrote:
>
> contrib/ChangeLog:
>
> * gcc-changelog/git_commit.py (GitCommit):
> Add support for 'Link:' tags.
>
> Cc: Jason Merrill <ja...@redhat.com>
I don't think we want a Cc: trailer in the actual commit message. do we?
What is a Link: tag? I assume this is some kind of Git trailer, but
what for? A URL? Why do we need to use a Git trailer for that instead
of just putting the URL in the commit message body?
> Signed-off-by: Alejandro Colomar <a...@kernel.org>
> ---
>
> Hi,
>
> This patch is needed by my patches that add _Countof.
>
>
> Have a lovely day!
> Alex
>
>
> contrib/gcc-changelog/git_commit.py | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/contrib/gcc-changelog/git_commit.py
> b/contrib/gcc-changelog/git_commit.py
> index 5645f80ebb9..5f5f3b9110a 100755
> --- a/contrib/gcc-changelog/git_commit.py
> +++ b/contrib/gcc-changelog/git_commit.py
> @@ -188,6 +188,7 @@ CO_AUTHORED_BY_PREFIX = 'co-authored-by: '
> REVIEW_PREFIXES = ('reviewed-by: ', 'reviewed-on: ', 'signed-off-by: ',
> 'acked-by: ', 'tested-by: ', 'reported-by: ',
> 'suggested-by: ')
> +LINK_PREFIXES = ('link: ')
> DATE_FORMAT = '%Y-%m-%d'
>
>
> @@ -529,6 +530,8 @@ class GitCommit:
> continue
> elif lowered_line.startswith(REVIEW_PREFIXES):
> continue
> + elif lowered_line.startswith(LINK_PREFIXES):
> + continue
> else:
> m = cherry_pick_regex.search(line)
> if m:
>
> Range-diff against v0:
> -: ----------- > 1: 0a752a02dd0 contrib/: Add support for Link: tags
> --
> 2.49.0
>
