Hi, David,
Thanks a lot for the info.
> On May 14, 2025, at 09:50, David Malcolm <dmalc...@redhat.com> wrote:
>
> On Mon, 2025-04-07 at 15:04 +0000, Qing Zhao wrote:
>
> [...snip...]
>
>> diff --git a/gcc/move-history-rich-location.cc b/gcc/move-history-
>> rich-location.cc
>> new file mode 100644
>> index 00000000000..120498d165e
>> --- /dev/null
>> +++ b/gcc/move-history-rich-location.cc
>
> [...snip...]
>
>> +
>> +/* Implemenation of the method make_inner_path of the class
>> + lazy_move_history_path. */
>> +
>> +std::unique_ptr<diagnostic_path>
>> +lazy_move_history_path::make_inner_path () const
>> +{
>> + auto path = std::make_unique<simple_diagnostic_path>
>> + (global_dc->get_reference_printer ());
>
> Hi Qing
>
> I added a param to simple_diagnostic_path's ctor in r16-413:
> https://gcc.gnu.org/pipermail/gcc-patches/2025-May/682784.html
> so I think the patch will need a little fixing up here for it to still
> compile against trunk (sorry!).
>
> I think you just need to change this to:
>
> auto path = std::make_unique<simple_diagnostic_path>
> (get_logical_location_manager (),
> global_dc->get_reference_printer ());
>
> so that the inner path uses the same logical_location_manager as the
> outer path.
I will do that.
>
> From a diagnostics point of view, I'm preapproving the updated version
> of the patch with that change, assuming it bootstraps and passes usual
> testing.
Will make sure no issue after the change.
Qing
>
> Dave
>
