On Tue, 3 Jun 2025, Andrew Pinski wrote:

> This is just a simple check to see if the flags like LangEnabledBy
> have the correct case. By putting everything into upper case and
> seeing if there is a match (if previously there was not a match).
> This would have caught PR 120078 much earlier.
> Tested both with and without the fix for PR 120078.

I think checking all flags against a global list of valid flags would be 
better than matching so specifically for the particular mistake in that 
PR.

-- 
Joseph S. Myers
josmy...@redhat.com

Reply via email to