On 04/06/2025 15:59, Jeff Law wrote:


On 5/29/25 6:46 AM, Alfie Richards wrote:
Add the assembler_name member to cgraph_function_version_info to store
the base assembler name of the funciton set, before FMV mangling. This is
Just a typo in the patch description.  Should be "function".
used in later patches for refactoring FMV mangling.

gcc/ChangeLog:

    * cgraph.cc (cgraph_node::insert_new_function_version): Record
    assembler_name.
    * cgraph.h (struct cgraph_function_version_info): Add assembler_name.
OK to push now assuming there isn't a dependency I'm missing.

In doing regression testing for pushing this I discovered it causes a regression for ix86 by calling DECL_ASSEMBLER_NAME earlier, so the default version doesn't get double mangled as it used to be.

This is fixed in my overhaul of FMV mangling [12/24] so am inclined to hold off on pushing this (and avoid fixing this bug temporarily) until that is approved as well.

If you'd prefer patches to be atomic I can merge this patch for the next version?

Alfie

Jeff


Reply via email to