Hi!
On Tue, Jul 01, 2025 at 12:14:32PM -0400, Michael Meissner wrote:
> This patch adds the support that can be used in developing GCC support
> for potential future PowerPC processors.
>
> These changes are being added so that hardware designers can evaluate
> potential new features to be added to the PowerPC processors in the
> future. It may be these features will be incorporated into real
> hardware using a different name in the future. Or it may be these
> features will not be incoporated into actual PowerPC hardware in the
> future.
None of this belongs in the commit message. In the furure please post
stuff exactly as you want it to be committed!
> * config/rs6000/rs6000-c.cc (rs6000_target_modify_macros): If
> -mcpu=future, define _ARCH_FUTURE.
> * config/rs6000/rs6000-cpus.def (FUTURE_MASKS_SERVER): New macro.
> (POWERPC_MASKS): Add OPTION_MASK_FUTURE.
> (future cpu): Add 'future' cpu.
> * config/rs6000/rs6000-tables.opt: Regenerate.
> * config/rs6000/rs6000.opt (-mfuture-internal): New internal option to
> indicate the user used -mcpu=future.
NAK, as said before.
If the user wants to see what rs6000_cpu is set to, the user should just
look at rs6000_cpu, don't go via more indirect roundabout ways.
> +/* At present, we are not providing a unique processor option for
> -mcpu=future.
What does this comment mean even?
> + Until we define these changes, just use the power11 defaults. */
> +RS6000_CPU ("future", PROCESSOR_POWER11, MASK_POWERPC64 |
> FUTURE_MASKS_SERVER)
It isn't talking about this code for sure.
> +;; Users should not use -mfuture-internal, but we need to use a bit to
> identify
> +;; when the user changes the default cpu via #pragma GCC target("cpu=future")
> +;; and then resets it later.
What does that mean? It hints at a bug elsewhere, but not more than
hints unfortunately.
Segher
