On Tue, Jul 15, 2025 at 2:04 PM Gerald Pfeifer <ger...@pfeifer.com> wrote: > > On Tue, 15 Jul 2025, Uros Bizjak wrote: > > LGTM for content, but let's ask Gerald to proofread the entry. > > Happy to! > > + <li>The <code>--enable-x86-64-mfentry</code> configure option is > + added to enable <code>-mfentry</code> for x86-64 by default to use > + <code>__fentry__</code>, instead of <code>mcount</code> for > + profiling. This option is enabled by default for glibc targets. > + </li> > > This feels a bit complex to parse. How about something like > > + <li>The new <code>--enable-x86-64-mfentry</code> configure option > + makes <code>-mfentry</code> use <code>__fentry__</code> instead > + of <code>mcount</code> for profiling on x86-64. This option is > + enabled by default for glibc targets. > + </li> > > This replaces "option is added to enable" by "new option makes", fixes > grammar/word order and drops what feels like an extra "by default".
-mfentry is the option to enable __fentry__. How about this v3 patch? > If the latter is wrong, add "by default" before "for profiling on x86-64". > > > What do you think? (If you like it, go ahead and push this new version.) > > Gerald -- H.J.
From c8741974d0fb720bb27bcae65c5e116d101ce011 Mon Sep 17 00:00:00 2001 From: "H.J. Lu" <hjl.to...@gmail.com> Date: Mon, 14 Jul 2025 20:32:11 +0800 Subject: [PATCH v3] gcc-16/changes.html: Add --enable-x86-64-mfentry Signed-off-by: H.J. Lu <hjl.to...@gmail.com> --- htdocs/gcc-16/changes.html | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/htdocs/gcc-16/changes.html b/htdocs/gcc-16/changes.html index cc6fe204..a700c59c 100644 --- a/htdocs/gcc-16/changes.html +++ b/htdocs/gcc-16/changes.html @@ -118,6 +118,13 @@ for general information.</p> <!-- <h3 id="x86">IA-32/x86-64</h3> --> + <li>The new <code>--enable-x86-64-mfentry</code> configure option + enables <code>-mfentry</code> automatically to use + <code>__fentry__</code>, instead of <code>mcount</code>, for + profiling on x86-64. This option is enabled by default for + glibc targets. + </li> + <h3 id="amdgcn">AMD GPU (GCN)</h3> <ul> -- 2.50.1
