Patrick Palka <ppa...@redhat.com> writes:
> On Sat, 26 Jul 2025, Nathaniel Shead wrote:
>
>> On Fri, Jul 25, 2025 at 08:58:47AM -0400, Patrick Palka wrote:
>> > On Fri, 25 Jul 2025, Nathaniel Shead wrote:
>> >
>> > > Bootstrapped and regtested on x86_64-pc-linux-gnu, OK for trunk?
>> > >
>> > > -- >8 --
>> > >
>> > > I noticed that C++26 trivial relocation didn't work in modules yet, and
>> > > there are a couple of other flags that seem potentially useful we
>> > > weren't streaming. This streams those flags and adds a comment to
>> > > cp-tree.h to help people remember about modules when adding more.
>> > >
>> > > As a drive-by improvement, update gcc_assert with gcc_checking_assert in
>> > > lang_type_bools streaming.
>> >
>> > LGTM
>> >
>>
>> Thanks! To clarify, I notice you're now a reviewer for the C++ frontend
>> (congratulations!); does this count as approval or should I wait for
>> Jason?
>
> Oops good point, I guess I should say "OK for trunk" now :) (and thanks!)
One of the new tests causes
+FAIL: g++.dg/modules/class-11_a.H -std=c++14 (test for excess errors)
+FAIL: g++.dg/modules/class-11_a.H module-cmi
(gcm.cache/\$srcdir/g++.dg/modules/class-11_a.H.gcm)
+FAIL: g++.dg/modules/class-11_b.C -std=c++14 (test for warnings, line 10)
+FAIL: g++.dg/modules/class-11_b.C -std=c++14 (test for excess errors)
Excess errors:
/vol/gcc/src/hg/master/local/gcc/testsuite/g++.dg/modules/class-11_a.H:23:44:
error: 'static_assert' without a message only available with '-std=c++17' or
'-std=gnu++17' [-Wc++17-extensions]
/vol/gcc/src/hg/master/local/gcc/testsuite/g++.dg/modules/class-11_a.H:36:43:
error: 'static_assert' without a message only available with '-std=c++17' or
'-std=gnu++17' [-Wc++17-extensions]
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
