On Tue, Jul 29, 2025 at 09:57:19PM +1000, Nathaniel Shead wrote:
> @@ -7114,8 +7121,10 @@ trees_in::core_vals (tree t)
> }
>
> RT (t->function_decl.personality);
> - RT (t->function_decl.function_specific_target);
> - RT (t->function_decl.function_specific_optimization);
> + /* These properties are not streamed, and should be reconstructed
> + from any function attributes. */
I'd just like to chime in on this. I'm afraid that is not possible,
because target/optimize attributes aren't the only way to add a non-standard
TARGET_OPTION_NODE/OPTIMIZATION_NODE to a FUNCTION_DECL, #pragma GCC
{target,optimize} can be used for that as well (and mixed with attributes).
I agree it is better to sorry than ICE for 15.2, but eventually it might be
better to stream the node. Of course it depends on how portable the modules
file format is and whether one can compile with one version of compiler and
use with say a few days later snapshot which could have some new option
added.
Jakub
