This one is LGTM :)
On Tue, Jul 22, 2025 at 6:04 AM Jeff Law <jeffreya...@gmail.com> wrote: > > > > On 7/11/25 2:57 AM, Kuan-Lin Chen wrote: > > This patch add basic support for the following XAndes ISA extensions: > > > > XANDESPERF > > XANDESBFHCVT > > XANDESVBFHCVT > > XANDESVSINTLOAD > > XANDESVPACKFPH > > XANDESVDOT > > > > gcc/ChangeLog: > > > > * config/riscv/riscv-ext.def: Include riscv-ext-andes.def. > > * config/riscv/riscv-ext.opt (riscv_xandes_subext): New variable. > > (XANDESPERF) : New mask. > > (XANDESBFHCVT): Ditto. > > (XANDESVBFHCVT): Ditto. > > (XANDESVSINTLOAD): Ditto. > > (XANDESVPACKFPH): Ditto. > > (XANDESVDOT): Ditto. > > * config/riscv/t-riscv: Add riscv-ext-andes.def. > > * doc/riscv-ext.texi: Regenerated. > > * config/riscv/riscv-ext-andes.def: New file. > > > > gcc/testsuite/ChangeLog: > > > > * gcc.target/riscv/xandes-predef-1.c: New test. > > * gcc.target/riscv/xandes-predef-2.c: New test. > > * gcc.target/riscv/xandes-predef-3.c: New test. > > * gcc.target/riscv/xandes-predef-4.c: New test. > > * gcc.target/riscv/xandes-predef-5.c: New test. > > * gcc.target/riscv/xandes-predef-6.c: New test. > This looks good to me. I haven't heard from Kito. So my thinking is > this can go in at any time since it doesn't depend on anything else. > > Jeff >