Hi Tamar and Andrew,

On Tue, Jul 29, 2025 at 10:23:20AM -0700, Andrew Pinski wrote:
> On Tue, Jul 29, 2025 at 1:44 AM Tamar Christina <tamar.christ...@arm.com> 
> wrote:
> >
> > ...
> >
> > > +/* { dg-do run }  */
> > > +/* { dg-require-ifunc "" } */
> > > +/* { dg-options "-Wno-experimental-fmv-target" } */
> > > +
> > > +#include <stdint.h>
> > > +
> > > +typedef struct {
> > > +  uint64_t size;
> > > +} ifunc_arg_t;
> > > +
> > > +#include "ifunc-resolver.in"
> >
> > Possibly silly question, but do we only support ifuncs on platforms
> > with mmap support? I'm wondering if these tests shouldn't also
> > require { dg-require-effective-target mmap } */
> 
> I think currently ifunc is only supported on targets that also have mmap
> but I don't think we should depend on that so yes adding
> dg-require-effective-target here is a good idea.

Added this to the tests, thanks for the feedback!

v3: 
https://inbox.sourceware.org/gcc-patches/20250730111807.421613-1-yury.khrusta...@arm.com/

Kind regards,
Yury

Reply via email to